tink: New search UI

help-wanted
tink

(Kat Marchán) #21

go ahead and open a PR!


(Kat Marchán) #22

and to answer your question: The “Right Way” to do it is to pass the entire opts object over to libnpm.search. Because of figgy-pudding, this is the way we handle the large number of npm-related options that are otherwise impractical to pass through layer by layer.


(Lars Willighagen) #23

Looks good! I’ll finish the updated PackageView soon.

As for feedback, one quick point: aliases seem to be handled at two levels, causing duplication in the tink help view. However, this is a problem for @zkat’s commands too.

Commands:
  tink completion  generate bash completion script
  tink shell       Launch a tink shell or execute a script         [aliases: sh]
  tink shell       Launch a tink shell or execute a script         [aliases: sh]
  tink search      Search the NPM registry                [aliases: s, se, find]
  tink search      Search the NPM registry                [aliases: s, se, find]
  tink search      Search the NPM registry                [aliases: s, se, find]
  tink search      Search the NPM registry                [aliases: s, se, find]
  tink prepare     pre-fetch all dependencies                    [aliases: prep]
  tink prepare     pre-fetch all dependencies                    [aliases: prep]
  tink ping        ping registry            [aliases: prep]

Good to know.


(Kat Marchán) #24

that’s a pretty new bug… @bcoe???


(Kat Marchán) #25

yes, this is accurate


(Chris Forrette) #26

OK, PR is open!

I’ll continue code discussion over there…


(Kat Marchán) #27

FYI: tink: Implement tink view was merged!