npm cli: Update banner links to non-existent github release


(Andreas Lind) #1

What I Wanted to Do

I ran npm install and got a notification that a new version was available:

   β”‚                                                               β”‚
   β”‚       New minor version of npm available! 6.1.0 β†’ 6.2.0       β”‚
   β”‚   Changelog:   β”‚
   β”‚               Run npm install -g npm to update!               β”‚
   β”‚                                                               β”‚

I copy/pasted the changelog link into my browser to see what’s new, but got a 404.

What Happened Instead is a 404

Reproduction Steps

  1. Run npm install with npm 6.1.0
  2. Wait for the notification of 6.2.0 being available to appear
  3. Paste the link into a browser


Platform Info

$ npm --versions
{ npm: '6.1.0',
  ares: '1.14.0',
  cldr: '33.0',
  http_parser: '2.8.0',
  icu: '61.1',
  modules: '64',
  napi: '3',
  nghttp2: '1.32.0',
  node: '10.4.1',
  openssl: '1.1.0h',
  tz: '2018c',
  unicode: '10.0',
  uv: '1.20.3',
  v8: '',
  zlib: '1.2.11' }
$ node -p process.platform

Changelog link is broken
New version notes has wrong changeLog link
New version warning points changelog to wrong url
NPM CLI Update notice is using the wrong url
Changelog url is outdated
npm suggests github for bugs
(Artem Varaksa) #2

This was already fixed in f0a372b :heavy_check_mark: , and the fix was released in v6.2.0. The correct changelog URL is:

(Aleksei Gurianov) #3

I am pretty sure this link evaluated in npm@6.1.0 and can’t be fixed already.
Though it is possible to make fake 6.2.0 release at original repo to point out to new one.

(Aleksei Gurianov) #4

But people with 6.1.0 installed still receives broken link in their console.
I’d suggest to temporally unfreeze original repo to create fake 6.2.0 release there.

(Artem Varaksa) #5

However, what about next releases? When the next version comes out, users of 6.1.0 will have a broken link again. We need to find a better solution, if such exists.

(Kat MarchΓ‘n) #6

I think this is just gonna have to be this way. Only a couple of releases actually display things this way (6.0.0, 6.0.1, and 6.1.0), and once users upgrade from there, they’ll never see this bug again.

The nature of npm update processes is that we’re kinda stuck with this kind of thing until everyone’s done updating from those versions :upside_down_face:.

(system) #7

This topic was automatically closed 90 days after the last reply. New replies are no longer allowed.