npm ci: check for matching between package-lock.json and package.json before removing node_modules


(Michael) #1

When npm ci complains about inconsistent package-lock.json/package.json it usually means that someone just changed package.json manually and did not invoked npm i afterwards, and then pushed to remote.
So when that happens I usually do npm i myself and then push correct package-lock to repo.

The problem is, when I figure this out It is already too late. npm ci is removing node_modules before anything else. So npm i does everything from zero. Which is slow. Which is annoying.


(Kat Marchán) #2

I’ll take a PR against libcipm to fix this.


(Lars Willighagen) #3

I’m on it, if that’s okay.


(Lars Willighagen) #4

https://github.com/zkat/cipm/pull/63


(Michael) #5

Is there something blocking this PR from merging?


(Lars Willighagen) #6

The holidays, probably.